Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces automatic ID generation for files created during initialization and removes redundant DVF structs.
- Automatically generates a new ID in the initialization flow.
- Replaces DumpedDVF with a unified CompleteDVF struct and updates related properties accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dvf.rs | Replaced DumpedDVF with CompleteDVF and introduced an ID generation call. |
| lib/dvf/parse.rs | Removed DumpedDVF, adjusted trait BasicDVF, and updated CompleteDVF struct fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initnow automatically gets an ID at the end. This was requested based on user feedback.DumpedDVFandBasicDVFbecause they were originally meant for features that are no longer needed. Just one DVF struct now. This way the ID can directly be generated.