Skip to content

feat: switch from snappy to snappyjs#15

Draft
twoeths wants to merge 7 commits intoChainSafe:masterfrom
twoeths:tuyen/snappyjs
Draft

feat: switch from snappy to snappyjs#15
twoeths wants to merge 7 commits intoChainSafe:masterfrom
twoeths:tuyen/snappyjs

Conversation

@twoeths
Copy link
Copy Markdown

@twoeths twoeths commented Aug 26, 2022

Motivation

  • Lodestar already used snappyjs so there is no need to introduce another dependency with same purpose
  • Lodestar only uses sync api
  • There's an external memory leak issue when we upgrade to esm, switching to snappyjs help reduce the risk because snappy calls to native layer

Description

  • Switch from tap to mocha
  • Switch from snappy to snappyjs
  • Remove asyncCompress option, only support sync api
  • migrate to esm
  • remove buffer-* dependencies

@twoeths twoeths changed the title Switch from tap to mocha feat: switch from tap to mocha Aug 26, 2022
@twoeths twoeths changed the title feat: switch from tap to mocha feat: switch from snappy to snappyjs Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet