Draft
Conversation
Contributor
Summary of ChangesHello @nazarhussain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant new feature: an assumption-based Fast Confirmation Rule (FCR) for the beacon node. The primary goal is to accelerate the confirmation of blocks by implementing a sophisticated algorithm that evaluates various network and validator-related metrics. This involves deep integration into the existing fork choice mechanism, providing a new configurable option for users, and updating how 'safe' blocks are identified within the system. The changes are comprehensive, spanning core logic, configuration, state management, and observability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fast confirmation rule, an experimental feature designed to provide faster block confirmations. The changes are comprehensive, including the core logic in a new FastConfirmationRule class, configuration options to enable it, and integration into the existing ForkChoice and safe block determination logic. The implementation appears to align well with the provided specification. My review includes a couple of minor suggestions to enhance code quality and readability.
|
|
||
| if (activeIndices !== null) { | ||
| for (const i of activeIndices) { | ||
| if (!state) continue; |
Contributor
There was a problem hiding this comment.
This null check for state is redundant. The activeIndices array is derived from state on line 241. If state were null, activeIndices would also be null, and this code block would not be entered. Therefore, state is guaranteed to be non-null here.
Suggested change
| if (!state) continue; | |
| if (state.validators.get(i)?.slashed) continue; |
Contributor
Author
There was a problem hiding this comment.
TS give error 'state' is possibly 'null' and don't want to use non-null assertion.
Comment on lines
+1676
to
+1684
| getTrackedVotesCount: () => { | ||
| let count = 0; | ||
| for (let i = 0; i < this.voteNextIndices.length; i++) { | ||
| if (this.voteNextIndices[i] !== NULL_VOTE_INDEX) { | ||
| count++; | ||
| } | ||
| } | ||
| return count; | ||
| }, |
Contributor
There was a problem hiding this comment.
For improved conciseness and readability, this loop can be replaced with the filter array method. This is more idiomatic in TypeScript and achieves the same result.
getTrackedVotesCount: () => {
return this.voteNextIndices.filter((i) => i !== NULL_VOTE_INDEX).length;
},
Contributor
Author
There was a problem hiding this comment.
We prefer for over other iterative approaches for performance reasons.
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Contributor
|
Hey @nazarhussain, we chatted about running FCR tests at the meeting today. This is how you can generate these tests:
This will write the tests to Note: There is currently a failing test with Gloas, which sort of breaks test generation. So you could generate the reference tests for a specific fork instead, something like the following. After Mikhail fixes the issue, you can use the command above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce assumption based fast confirmation rule.
Description
Specs: ethereum/consensus-specs#4747