Merged
Conversation
dapplion
commented
Dec 19, 2022
| } | ||
|
|
||
| async produceBlindedBlock(blockAttributes: BlockAttributes): Promise<allForks.BlindedBeaconBlock> { | ||
| produceBlindedBlock(blockAttributes: BlockAttributes): Promise<allForks.BlindedBeaconBlock> { |
Contributor
Author
There was a problem hiding this comment.
Unnecessary async function
| private readonly config: IChainForkConfig; | ||
| private readonly genesisTime: number; | ||
| private timeoutId: NodeJS.Timeout; | ||
| private timeoutId: number | NodeJS.Timeout; |
Contributor
Author
There was a problem hiding this comment.
Allows to compile with any recent @types/node version. Has caused issues when installing individual local packages like c-kzg
|
|
||
| it("default != other", () => { | ||
| const chainConfigJson = chainConfigToJson(chainConfig); | ||
| const ALTAIR_FORK_EPOCH = 10; |
Contributor
Author
There was a problem hiding this comment.
Make test deterministic test independent of current values of the default chain spec
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
They are valuable but barely deserve individual PRs. Feel free to 👎 if the scope of this PR is too wide and should be split or re-done
Description
Misc changes from eip-4844 branch