EIP-4844: Add c-kzg library and current trusted setup#4851
Merged
Conversation
dapplion
force-pushed
the
dapplion/c-kzg
branch
from
df9685f to
130e85e
Compare
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
reviewed
Dec 5, 2022
| // Solutions: https://stackoverflow.com/questions/46745014/alternative-for-dirname-in-node-js-when-using-es6-modules | ||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
| export const TRUSTED_SETUP_BIN_FILEPATH = path.join(__dirname, "../../trusted_setup.bin"); |
Contributor
There was a problem hiding this comment.
would this be network dependent or same setup will work for all networks (and then the question of chains like gnosis etc)
Contributor
Author
There was a problem hiding this comment.
Still unknown, probably it will be shared since it's only dependant on the size of blobs. I would bet big on being the same file for all eth2 networks
g11tech
approved these changes
Dec 5, 2022
Contributor
g11tech
left a comment
g11tech
left a comment
There was a problem hiding this comment.
lgtm, just a query regarding the trusted bin customization w.r.t. networks
twoeths
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
EIP-4844 needs a new crypto backend, which will co-exist to BLST. It also needs access to a network specific trusted setup, which is a list of G1 and G2 points
Description