Skip to content
This repository was archived by the owner on Jun 12, 2023. It is now read-only.

fix: Update shasum for MetaMask Flask version 10.31.0-flask.0 #260

Closed
vorburger wants to merge 1 commit into from
Closed

fix: Update shasum for MetaMask Flask version 10.31.0-flask.0 #260

vorburger wants to merge 1 commit into from

Conversation

@vorburger
Copy link

@vorburger vorburger commented Jun 4, 2023 •
edited
Loading

I suspect this should fix #258.

Can I get some... FIL... something... GitCoin... whatever... 🥇 appreciation 😼 for this?

@vorburger vorburger mentioned this pull request Jun 4, 2023
Open
@vorburger
Copy link
Author

vorburger commented Jun 4, 2023

license/cla Expected — Waiting for status to be reported

How / where do I sign your CLA?

@vorburger vorburger mentioned this pull request Jun 5, 2023
Closed
@mpetrunic
Copy link
Member

mpetrunic commented Jun 5, 2023

license/cla Expected — Waiting for status to be reported

How / where do I sign your CLA?

We don't have CLA on this repo, status check was some remnant from before

@vorburger
Copy link
Author

vorburger commented Jun 7, 2023

@mpetrunic ACK, the CLA Check has now disappeared. But there is now a build failure due to:

Run echo "Snap manifest not updated: packages/snap/snap.manifest.json"
Snap manifest not updated: packages/snap/snap.manifest.json
Error: Process completed with exit code [1](https://github.com/ChainSafe/filsnap/actions/runs/5171557832/jobs/9321252724?pr=260#step:10:1).

which... doesn't really make a whole lot of sense? This PR IS updating packages/snap/snap.manifest.json, so there must be something wrong with that check.

@vorburger vorburger mentioned this pull request Jun 7, 2023
Closed
@mpetrunic
Copy link
Member

mpetrunic commented Jun 7, 2023

@mpetrunic ACK, the CLA Check has now disappeared. But there is now a build failure due to:

Run echo "Snap manifest not updated: packages/snap/snap.manifest.json"
Snap manifest not updated: packages/snap/snap.manifest.json
Error: Process completed with exit code [1](https://github.com/ChainSafe/filsnap/actions/runs/5171557832/jobs/9321252724?pr=260#step:10:1).

which... doesn't really make a whole lot of sense? This PR IS updating packages/snap/snap.manifest.json, so there must be something wrong with that check.

Just checked locally, you didn't do something right, the shasum on master is the correct one.
What commands did you run to get this sha?

@mpetrunic mpetrunic closed this Jun 7, 2023
@vorburger
Copy link
Author

vorburger commented Jun 7, 2023

Just checked locally, you didn't do something right, the shasum on master is the correct one.

@mpetrunic nope, I have to most respectfully disagree with you, that seems to be broken, and causes #258, as also reported e.g. on #257, because of MetaMask/snaps#1304, as confirmed by @FrederikBolding. To the best of my knowledge, this PR should fix that issue. Perhaps you could consider re-opening this PR?

What commands did you run to get this sha?

I have documented that here.

@mpetrunic mpetrunic mentioned this pull request Jun 7, 2023
Open
@mpetrunic
Copy link
Member

mpetrunic commented Jun 7, 2023

You forgot to update snaps-cli and build error related to that update in your PR. Replaced by #261

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BeroBurny BeroBurny Awaiting requested review from BeroBurny

@irubido irubido Awaiting requested review from irubido irubido is a code owner

@mpetrunic mpetrunic Awaiting requested review from mpetrunic mpetrunic is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to fetch Snap "npm:@chainsafe/filsnap": Invalid Snap manifest: manifest shasum does not match computed shasum..

2 participants

@vorburger @mpetrunic