Skip to content

Conversation

@Lykhoyda
Copy link
Contributor

@Lykhoyda Lykhoyda commented Dec 3, 2024

Web Wallet package:

  • Add Home page
  • Connect to Metmask Snap

@Lykhoyda Lykhoyda self-assigned this Dec 3, 2024
@Lykhoyda Lykhoyda requested a review from ec2 December 3, 2024 16:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +29 to +32
<p className="font-inter">
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
eiusmod tempor incididunt ut labore et dolore magna aliqua.
</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a proper text yet 😃

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a bit tricky have multiple problems
First, let go with EIP-6963, it's not a provider. The purpose of that EIP is to discover all available EIP-1193 providers. We can go into details over a call or please check the specification

To simplify account discovery there is already made packages mipd

Last note, I'm discouraging using windows.ethereum as a creation of EIP-6963 is here to combat wallet wars over namespace and you cannot know in any time if some wallet will override it

@Lykhoyda Lykhoyda merged commit fe47cf2 into main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants