Store seed in relinkey #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamK-CR
reviewed
Dec 21, 2025
|
|
||
| namespace lbcrypto { | ||
|
|
||
| inline std::vector<uint32_t> GenerateRandomSeed(size_t size) { |
There was a problem hiding this comment.
Better to use the existing implementation if it isn't too difficult.
|
|
||
| // 2. Absorb the seed (inject entropy) | ||
| // We cast the vector to bytes for absorption | ||
| if (!seed.empty()) { |
| for (uint16_t seg_i = 0; seg_i < 2048; ++seg_i){ | ||
| std::unique_ptr<PRNG> shake128engine = std::make_unique<Shake128Engine>(m_seed,m_salt,qIndex,seg_i); | ||
|
|
||
| std::uniform_int_distribution<uint32_t> dist(DUG_CHUNK_MIN, DUG_CHUNK_MAX); |
Comment on lines
174
to
178
| // Convert 32-bit word to 4 bytes (little-endian) | ||
| digest[4*i] = static_cast<uint8_t>(word & 0xFF); | ||
| digest[4*i + 1] = static_cast<uint8_t>((word >> 8) & 0xFF); | ||
| digest[4*i + 2] = static_cast<uint8_t>((word >> 16) & 0xFF); | ||
| digest[4*i + 3] = static_cast<uint8_t>((word >> 24) & 0xFF); |
There was a problem hiding this comment.
Not necessary, you can do rejection here, or directly construct 42 words
| // ----------------------------------------------------------------------------- | ||
| // Function: extract_32_words_from_digest | ||
| // ----------------------------------------------------------------------------- | ||
| inline std::array<int32_t, 32> extract_32_words_from_digest(const std::array<uint8_t, 168>& digest, uint32_t q) { |
There was a problem hiding this comment.
See if this works:
Suggested change
| inline std::array<int32_t, 32> extract_32_words_from_digest(const std::array<uint8_t, 168>& digest, uint32_t q) { | |
| template <typename VecType> | |
| inline std::array<int32_t, 32> extract_32_words_from_digest(const std::array<uint8_t, 168>& digest, VecType::Integer &q) { |
| private: | ||
|
|
||
| protected: | ||
| typename VecType::Integer m_modulus{}; |
Comment on lines
56
to
57
| template <typename VecType> | ||
| class DiscreteUniformGeneratorCRImpl : public DiscreteUniformGeneratorImpl<VecType> { |
There was a problem hiding this comment.
Suggested change
| template <typename VecType> | |
| class DiscreteUniformGeneratorCRImpl : public DiscreteUniformGeneratorImpl<VecType> { | |
| class DiscreteUniformGeneratorCRImpl : public DiscreteUniformGeneratorImpl<NativeVector> { |
fixed test serialized data size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.