Skip to content

Conversation

@aditya0by0
Copy link
Member

@aditya0by0 aditya0by0 commented Jun 24, 2025

@aditya0by0 aditya0by0 self-assigned this Jun 24, 2025
@aditya0by0
Copy link
Member Author

I'm reviewing the current list of dependencies and noticed the following packages may not be directly required by chebai, as I couldn't find any explicit imports for them in the codebase:

svgutils
scikit-network
typing-extensions
urllib3
threadpoolctl
six
pytz
python-dateutil
joblib
certifi
idna
chardet
pyyaml

Some of these might be transitive dependencies pulled in by other libraries, but they don't appear to be directly used.

Also, the following packages are only used in Jupyter notebooks or for visualization or logging:

wandb
seaborn
matplotlib

Would it make sense to move these to optional dependencies in the toml file?

@aditya0by0 aditya0by0 requested a review from sfluegel05 June 24, 2025 22:31
@aditya0by0 aditya0by0 linked an issue Jun 25, 2025 that may be closed by this pull request
@aditya0by0 aditya0by0 marked this pull request as ready for review July 6, 2025 09:55
@aditya0by0
Copy link
Member Author

1083a22
This commit addresses the formatting issues we discussed related to the GitHub Actions workflow. Previously, the workflow was using the latest version of Black, while our local machines used older versions specified in pre-commit hooks, causing inconsistencies.

Now, the versions are fixed and aligned in both the GitHub Actions and the pre-commit configuration. This ensures consistent formatting across all environments.

Note: Users will need to update their local pre-commit hooks after pulling these changes to sync with the updated .pre-commit-config.yaml.

@sfluegel05
Copy link
Collaborator

That's great. I have merged the dev branch into this branch and was able to get the lint checks to pass (meaning the pre-commit hooks are working). However, the unittests are failing. @aditya0by0 Could you have a look at that? I feel like we have had this error before, but I can't put my finger on it right now.

@sfluegel05
Copy link
Collaborator

This is working now as well. I moved wandb to the optional dependencies and updated the readme.

@sfluegel05 sfluegel05 merged commit f2d62fd into dev Jul 14, 2025
7 checks passed
@aditya0by0 aditya0by0 deleted the feature/pyproject.toml branch July 14, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Packaging should be updated to pyproject.toml

3 participants