Skip to content

Fix input_dim and out_dim Not getting saved in model checkpoint #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfluegel05 merged 3 commits into from
Jul 14, 2025
Merged

Fix input_dim and out_dim Not getting saved in model checkpoint #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1285e5a
add out_dim to hparams explicitly
aditya0by0 Jun 13, 2025
ea28280
Merge branch 'dev' into fix/save_out_dim_to_checkpoint
sfluegel05 Jul 11, 2025
d18dd7a
Merge branch 'dev' into fix/save_out_dim_to_checkpoint
aditya0by0 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions chebai/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ def __init__(
if exclude_hyperparameter_logging is None:
exclude_hyperparameter_logging = tuple()
self.criterion = criterion
assert out_dim is not None, "out_dim must be specified"
assert input_dim is not None, "input_dim must be specified"
self.out_dim = out_dim
self.input_dim = input_dim

self.save_hyperparameters(
ignore=[
"criterion",
Expand All @@ -59,10 +64,8 @@ def __init__(
]
)

self.out_dim = out_dim
self.input_dim = input_dim
assert out_dim is not None, "out_dim must be specified"
assert input_dim is not None, "input_dim must be specified"
self.hparams["out_dim"] = out_dim
self.hparams["input_dim"] = input_dim

if optimizer_kwargs:
self.optimizer_kwargs = optimizer_kwargs
Expand Down