Skip to content

Token Indexer Reader abstract class #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfluegel05 merged 1 commit into from
May 8, 2025
Merged

Token Indexer Reader abstract class #88

sfluegel05 merged 1 commit into from
May 8, 2025

Conversation

@aditya0by0
Copy link
Member

@aditya0by0 aditya0by0 commented May 7, 2025 •
edited
Loading

  • Add an abstract class for indexing tokens, so other readers like ProteinDataReader can take advantage of this structure through inheritance, without need to duplicate the code.

@aditya0by0 aditya0by0 self-assigned this May 7, 2025
@aditya0by0 aditya0by0 linked an issue May 7, 2025 that may be closed by this pull request
Optimize Token Indexing in Reader class by Using Dictionary for Constant-Time Lookup #81
Closed
@aditya0by0 aditya0by0 requested a review from sfluegel05 May 7, 2025 10:12
@aditya0by0
Copy link
Member Author

aditya0by0 commented May 7, 2025

@sfluegel05, Please review and merge.

@sfluegel05 sfluegel05 marked this pull request as ready for review May 8, 2025 11:28
sfluegel05
sfluegel05 approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator

@sfluegel05 sfluegel05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense

@sfluegel05 sfluegel05 merged commit 94f6710 into dev May 8, 2025
8 checks passed
@sfluegel05 sfluegel05 deleted the index-reader-abstract-class branch May 8, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfluegel05 sfluegel05 sfluegel05 approved these changes

Assignees

@aditya0by0 aditya0by0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize Token Indexing in Reader class by Using Dictionary for Constant-Time Lookup

3 participants

@aditya0by0 @sfluegel05