set out_dim dynamically
#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skips data setup in the constructor; methods will be called later according to the CLI workflow. - This change enables to skip these methods during initialization for unit-testing GitHub CI/CD
- prepare_data and setup method should be called only after the most derived based class is full instantiated
- @DataClass to avoid conflicts with stack frame of save_hyperparameters()
- after doing certain common processing the `prepare_data` method calls the _perform_data_preparation method which contain core logic for data preparation
sfluegel05
approved these changes
Apr 16, 2025
Collaborator
sfluegel05
left a comment
sfluegel05
left a comment
There was a problem hiding this comment.
This seems to be the easiest solution for now. Thanks for implementing this.
I removed the changes for the GO datasets and added them to the protein repository instead: ChEB-AI/python-chebai-proteins@b45b266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
out_dimdynamically #73Dependency with below PRs (should only be merged after below PRs are merged)