Skip to content

Conversation

@aditya0by0
Copy link
Member

@aditya0by0 aditya0by0 requested a review from sfluegel05 July 30, 2025 16:30
@aditya0by0 aditya0by0 self-assigned this Jul 30, 2025
@aditya0by0 aditya0by0 added enhancement New feature or request priority: high labels Jul 30, 2025
@aditya0by0 aditya0by0 marked this pull request as ready for review August 9, 2025 22:02
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the extras-system correctly, given the dependencies

dependencies = ["A"]
[project.optional-dependencies]
opt1 = ["B"]
opt2 = ["C"]

you will get the following install options:

pip install my_package -> installs A
pip install my_package[opt1] -> installs A and B
pip install my_package[all] -> installs A, B and C

Given this structure, I would set the dependencies you put under inference as dependencies and make the rest optional (please correct me if I got this wrong)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfluegel05, Thanks for pointing this out. I have made changes as per your suggestion. Please review.

@aditya0by0
Copy link
Member Author

As this PR and the change (https://github.com/ChEB-AI/python-chebai/pull/105/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88L27-R28) in another PR has conflicting change, it will be better to merge the another PR first and then merge the dev with this PR, to keep the corresponding change from this PR.

Final change to this dev should be the below
python -m pip install -e .[dev]

@sfluegel05
Copy link
Collaborator

can you split the dev dependencies into two parts? I see 2 distinct use cases: a) use chebai to generate datasets and train models, b) develop chebai and commit things to the repo (only the latter need things like pre-commit)

@sfluegel05
Copy link
Collaborator

this should be fine now. I removed some dependencies that appeared twice and pinned lightning to 2.5.1 (#124).

Also, I had some performance issues while installing chebai. It turns out that I had some large files in the repository (data, model checkpoints, ...) that were scanned during installation. I changed [tool.setuptools.packages.find] s.t. only chebai is scanned

@sfluegel05 sfluegel05 changed the title Model Inference Dependencies - Dynamic imports split dependencies into inference (mandatory), training and linters Sep 19, 2025
@sfluegel05 sfluegel05 merged commit 8e51a61 into dev Sep 19, 2025
6 checks passed
@sfluegel05 sfluegel05 deleted the fix/model-inference-dependencies branch September 19, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants