Fix: Use __name__ instead of custom NAME attribute for class registration #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the model registration logic to use Python's built-in
cls.__name__instead of a customcls.NAMEattribute when checking and storing class references in_MODEL_REGISTRY.🔍 Reason for the change:
cls.__name__is more robust and Pythonic—it ensures every class is uniquely identified by its actual class name without relying on the presence or consistency of a manually definedNAMEattribute.cls.NAMEmay be missing, misdefined, or inconsistent across subclasses.This should make subclass registration safer and eliminate silent bugs due to missing or duplicate
NAMEattributes.