Types: Fix JSDoc on ResourceLoader constructors#13209
Open
donmccurdy wants to merge 1 commit intomainfrom
Open
Types: Fix JSDoc on ResourceLoader constructors#13209donmccurdy wants to merge 1 commit intomainfrom
donmccurdy wants to merge 1 commit intomainfrom
Conversation
|
Thank you for the pull request, @donmccurdy! ✅ We can confirm we have a CLA on file for you. |
6 tasks
donmccurdy
force-pushed
the
donmccurdy/refactor/classes-resourceloader-jsdoc
branch
from
d4dbf0a to
66f2a5c
Compare
Contributor
|
Just curious: Could there be a way to detect this automatically? (Without larger efforts and side-effects, that is - i.e. without enabling checks somewhere in the code that should not (yet) be enabled) |
6 tasks
Member
Author
|
Don't see why not. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick followup for an issue missed in #13201.
Issue number and link
Testing plan
All loaders in this PR are private and excluded from documentation and published type definitions, so the production effects of this PR should be zero. However, having the
@paramtags correctly moved to the constructors will matter once we start enabling type checking on code relying on these loaders internally.Author checklist
CONTRIBUTORS.mdI have updatedCHANGES.mdwith a short summary of my changeI have added or updated unit tests to ensure consistent code coveragePR Dependency Tree
This tree was auto-generated by Charcoal