Fix nested internal library function call analysis in Certora Prover #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The static analysis was failing with critical errors when encountering nested internal library function calls (e.g., LibraryA.internalFunc() calling LibraryB.internalFunc()). The error occurred because the validator was too strict when matching internal function hints with their expected signatures.
Solution:
Enhanced the FunctionFlowAnnotator to handle nested library calls more gracefully by implementing several key improvements:
Added checkIfNestedLibraryCall() function
Implemented tryAlternativeResolution() function
Enhanced validateIds() function
Added inferTypeLayoutFromMethod() helper
Implementation Details:
Code Quality:
This fix enables Certora Prover to successfully verify contracts that use nested internal library function calls, which was previously causing verification failures.
Should fix issue #22