Feature/feedback #78
Open
Feature/feedback #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktaal
reviewed
Nov 17, 2025
Contributor
oktaal
left a comment
oktaal
left a comment
There was a problem hiding this comment.
Some random nitpicking but Let's deploy to production
| main_question_id = line[4] | ||
| main_question = line[7] | ||
| sub_question = line[5] | ||
| sub_question = line[5] if line[5] not in ['', ' ', ' '] else 'clausal' |
Contributor
There was a problem hiding this comment.
Maybe replace with:
sub_question = 'clausal' if not line[5] or line[5].isspace() else line[5]
Contributor
There was a problem hiding this comment.
(or if you know for sure it is not None then only not line[5].isspace())
| placeholder: $localize`Select Sub-Question(s)` | ||
| }, { | ||
| name: $localize`Sub-Question Text`, | ||
| // name: $localize`Sub-Question`, |
Contributor
There was a problem hiding this comment.
You can just remove the uncommented code
| of languages/language varieties that proved interesting for our research purposes. Next, we made | ||
| questionnaires | ||
| to | ||
| The database contains 33,384 translations of 252 prompts (including unattested patterns), from 326 |
Contributor
There was a problem hiding this comment.
The translations have to be updated and could these counts come from https://github.com/CentreForDigitalHumanities/mima/blob/feature/feedback/frontend/build/count-tokens.js? (or at least make that into a separate issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voila, feedback van Norbert, Marta, en Lex verwerkt. Geen wereldverschuivende aanpassingen volgens mij.