Merged
Conversation
Change repository to Maven Central for Gurobi, and change import to the correct package.
The default value for project.dir of "" in the `ConfigUtilsTest` would cause tests to fail is the user could not create the file `\XXX.log`. The logging configuration file is also updated to create a specific `.wrims/logs/runs` folder to track these logs that fall-through.
|
dwr-ycheng
approved these changes
Dec 22, 2025
dwr-ycheng
left a comment
dwr-ycheng
left a comment
There was a problem hiding this comment.
For the commit related to update of Gurobi version, the updates make sense. I spent most of the time comparing code differences in the GurobiSolver.java. no major changes to the code, mainly just rearrangement of the modules within the code.
For the commit related to bugfix, the code changes are minor, replacing WRIMS_LOG_DIR with WRIMS_FALLBACK_LOG_DIR.
github-project-automation
bot
moved this from Needs Review
to Done
in WRIMS 3 Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #163, new PR created to not conflict with ongoing work by UC Davis.
Description
Update the
gurobiversion used from5to11.0.3. This update also allows us to use the Gurobi jar from Maven Central.Changes were needed in the gradle files to change the version, and some external repositories were deleted since we didn't need to source the version
5anymore. Changes to source code were needed to importcom.gurobi.gurobi.*;, instead ofgurobi.*.closes #161 .