Feature/full logging for infeasibility cycles#177
Merged
dwr-hzamanisabzi merged 9 commits intomainfrom Dec 18, 2025
Merged
Conversation
dwr-hzamanisabzi
requested review from
dwr-zroy,
hxiedwr and
jmdegeorge
as code owners
dwr-zroy
requested changes
Dec 15, 2025
Collaborator
dwr-zroy
left a comment
dwr-zroy
left a comment
There was a problem hiding this comment.
Things look good. Some final housekeeping things, and one thought.
wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControllerBatch.java
Outdated
Show resolved
Hide resolved
wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControllerBatch.java.bak
Outdated
Show resolved
Hide resolved
wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControllerBatch.java
Outdated
Show resolved
Hide resolved
wrims-core/src/main/java/gov/ca/water/wrims/engine/core/components/ControllerBatch.java
Outdated
Show resolved
Hide resolved
dwr-zroy
approved these changes
Dec 18, 2025
Collaborator
dwr-zroy
left a comment
dwr-zroy
left a comment
There was a problem hiding this comment.
Looks good. I did a final check on my machine, and things look good. We should eventually benchmark the runtimes with the new solver call structure. Go ahead and merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see discussion on PR #152.