Conversation
There was a problem hiding this comment.
Code Review
This pull request implements native social login for Kakao and Apple by establishing a bridge between the mobile app and the web view. It introduces expo-apple-authentication, @react-native-kakao/user, and expo-secure-store for secure token management. The changes include new mobile API handlers, bridge methods for authentication, and refactoring the web application's login logic to leverage native SDKs. Review feedback highlights the need for stricter environment variable validation, correction of React Hook dependency arrays to prevent closure issues, and the removal of a duplicate enum value in the API type definitions.
There was a problem hiding this comment.
우선순위가 높은 작업은 아니지만, app.config.ts에서 app.json 오버라이딩 대신 app.config.ts로 합치고 app.json 제거해도 좋을거 같아요!
seseoju
left a comment
There was a problem hiding this comment.
네이티브 로그인으로 전환되면서 웹 환경에서 로그인 하는 경우에는 기존처럼 로그인하도록 추가적으로 처리도 해야 할것 같네요~! 고생하셨습니다!!👏
🛠️ 변경 사항
세부 변경 내용
performKakaoLogin,performAppleLogin)authStorage구현app.config.ts에 카카오 SDK 플러그인 설정 추가apiTypes.ts타입 정의 확장🔍 관련 이슈
📸 스크린샷 / GIF (선택)
authStorage가 토큰을 저장하는 방식 검토🔄 연관 작업