Update search pipe to allow searching on a moment object.toString#1
Open
anhany wants to merge 1 commit intoCenteva:masterfrom
anhany:master
Open
Update search pipe to allow searching on a moment object.toString#1anhany wants to merge 1 commit intoCenteva:masterfrom anhany:master
anhany wants to merge 1 commit intoCenteva:masterfrom
anhany:master
Conversation
marbletravis
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a moment date object, which is formatted in-line to a format that is more legible than the default format. I'd like the ability to search for that string as if it were just another string.
The private method simply casts the value that is given to it as a moment.Moment type, then makes sure it has the format method. Then, once it has format, we set the formatted string back in, and perform the search.
I also added some tests around the rest of the basic functionality of said search pipe. I'll have to add a WallabyJS configuration file another day.