Skip to content

fix: delete existing destination file before rename in DiskObjectStorage #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdeffendol merged 2 commits into from
Dec 22, 2025
Merged

fix: delete existing destination file before rename in DiskObjectStorage #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9fe62d
fix: delete existing destination file before rename in DiskObjectStorage
Dec 22, 2025
7892688
Adds unit test for RenameAsync when the destination file already exists
Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Centeva.ObjectStorage/Builtin/DiskObjectStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ public Task RenameAsync(StoragePath sourcePath, StoragePath destinationPath, Can

if (File.Exists(filePath))
{
if (File.Exists(newFilePath))
File.Delete(newFilePath);
File.Move(filePath, newFilePath);
}

Expand Down
33 changes: 33 additions & 0 deletions test/Centeva.ObjectStorage.IntegrationTests/CommonObjectStorageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,39 @@ public async Task RenameAsync_RenamesObject()
content.ShouldBe(_testFileContent);
}

[Fact]
public async Task RenameAsync_WithExistingDestination_OverwritesDestination()
{
// Arrange
var originalPath = await WriteToRandomPathAsync();
var destinationPath = RandomStoragePath();

// Create a copy at the destination path first
var differentContent = "Different content that should be overwritten.";
await _sut.WriteAsync(destinationPath, new MemoryStream(Encoding.UTF8.GetBytes(differentContent)));

// Verify both files exist before rename
(await _sut.ExistsAsync(originalPath)).ShouldBeTrue();
(await _sut.ExistsAsync(destinationPath)).ShouldBeTrue();

// Act
await _sut.RenameAsync(originalPath, destinationPath);

// Assert
// Check that the original object no longer exists
(await _sut.ExistsAsync(originalPath)).ShouldBeFalse();

// Check that the destination object still exists
(await _sut.ExistsAsync(destinationPath)).ShouldBeTrue();

// Check that the destination content matches the original content
using var stream = await _sut.OpenReadAsync(destinationPath);
stream.ShouldNotBeNull();
using var reader = new StreamReader(stream!);
var content = await reader.ReadToEndAsync();
content.ShouldBe(_testFileContent);
}

[Fact]
public async Task GetAsync_RetrievesStorageEntry()
{
Expand Down