[ENG-9692] upgrates part 1: pyproject.toml + poetry #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felliott
approved these changes
Dec 18, 2025
Member
felliott
left a comment
felliott
left a comment
There was a problem hiding this comment.
I've added some comments around which versions we do / do not support, but none of these are blockers. Otherwise looks good!
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", |
| "Framework :: Django :: 3.1", | ||
| "Framework :: Django :: 3.2", | ||
| "Framework :: Django :: 4.0", | ||
| "Framework :: Django :: 4.1", |
Member
There was a problem hiding this comment.
Likewise should we remove 1.11, 2.*, and 3.1?
| matrix: | ||
| python: ['3.6', '3.7', '3.8', '3.9', '3.10'] | ||
| django: ['1.11', '2.0', '2.1', '2.2', '3.0', '3.1', '3.2', '4.0', '4.1'] | ||
| python: ['3.8', '3.9', '3.10'] |
Member
There was a problem hiding this comment.
Why test 3.8 and 3.9 when the README and pyproject.toml both state python>=3.10?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pywithpyproject.tomlpoetryfor dependencies and packagingnote: github actions hasn't been running on this repo -- verified tests pass with py3.10 and dj4.1; will require passing tests on full version ranges (up to latest) before merging feature branch to
main