Skip to content

Conversation

@cslzchen
Copy link

@cslzchen cslzchen commented Nov 19, 2025

Ticket

https://openscience.atlassian.net/browse/ENG-5529
https://openscience.atlassian.net/browse/ENG-9940

Purpose

Notifications Refactor - Angular FE Support

Changes

Fix notification frequency enum

Johnetordoff and others added 4 commits October 30, 2025 08:52
feat(enums): update enum for notification refactor node settings page
Merge develop into feature branch
…rect notif (#761)

- Ticket: https://openscience.atlassian.net/browse/ENG-9758
- Feature flag: n/a

## Purpose

Make the notification preferences default and change to correct values. Corrosponses with this PR:
CenterForOpenScience/osf.io#11441

## Summary of Changes

Simple logic changes to make dropdowns functional
@coveralls
Copy link
Collaborator

coveralls commented Nov 19, 2025

Coverage Status

coverage: 55.524%. remained the same
when pulling 077575b on feature/notifications-refactor
into 6d39ae5 on develop.

…t to cor…" (#780)

Reverts #761

Reason: this breaks notification settings for `Preprint submissions updated`

This reverts commit 9aa505d.
@cslzchen cslzchen changed the title [Reference PR] Notification Refactor FE Support [ENG-5529] Notification Refactor FE Support Dec 16, 2025
@cslzchen cslzchen marked this pull request as ready for review December 16, 2025 01:45
@cslzchen cslzchen changed the title [ENG-5529] Notification Refactor FE Support [ENG-5529] [ENG-9940] Notification Refactor FE Support Dec 16, 2025
Copy link
Contributor

@Ostap-Zherebetskyi Ostap-Zherebetskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants