Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cubap
requested changes
Nov 17, 2025
Member
cubap
left a comment
cubap
left a comment
There was a problem hiding this comment.
There are a few things to take care of with a constant you are changing in some cases. I can't help but think this would be simpler if you did the http/s processing just when you loaded these things, but this cannon seems to hit everything.
|
|
||
| li.setAttribute("data-expanded", "true") | ||
| cachedFilterableEntities.set(obj["@id"].replace(/^https?:/, 'https:'), obj) | ||
| const negotiatedId = obj["@id"] ?? obj.id |
| const containingListElem = elem.closest("deer-view") | ||
| // Be careful. The publish list stores items via http://, but everything else is https://. Beware the false mismatch. | ||
| const glossID = obj["@id"].replace(/^https?:/, 'https:') | ||
| const negotiatedId = obj["@id"] ?? obj.id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a high level, discovered while trying to delete glosses. Some annotations failed the '@id' check and caused the loop to stop, so the Gloss entity itself was never deleted. Which Annotations were deleted were random.
Discovered that id negotiating is screwing us up at the Annotation level. Good lord. Everything id negotiates now.