Camera fix and code imrovements #28
Conversation
| constructor () { | ||
| super() | ||
| constructor() { | ||
| super(); |
There was a problem hiding this comment.
do not use the semicolon(;) at the end of a line
| // Event Handlers | ||
| onCheckBoxPress () { | ||
| if (this.state.checked) { | ||
| pressCheckbox(){ |
There was a problem hiding this comment.
follow function name convention
functionName () is correct
functionName() is not correct
| backgroundColorLeft: {backgroundColor: 'rgba(255,255, 255, 0.2)', borderColor: 'rgba(255,255, 255, 0)'}, | ||
| backgroundColorRight: {backgroundColor: 'rgba(255,255, 255, 0)', borderColor: 'rgba(255,255, 255, 0.2)'} | ||
| } | ||
| // this.state = { |
There was a problem hiding this comment.
delete commented code if it's not TODO or similar
There was a problem hiding this comment.
also, every component should have the constructor, usually state should be managed from there
| this.setState({btnTxt: 'Take a photo'}) | ||
| const currentStep = this.state.step | ||
| if (currentStep === 1) { | ||
| this.setState({btnTxt: 'Take a photo'}) |
There was a problem hiding this comment.
setState is asynchronous
It’s uncommon to call setState multiple times from the same block of code (e.g. an event callback)
There was a problem hiding this comment.
| var camera = this.props.showDocCamera ? | ||
| <Camera style={{ flex: 1 }} type={this.state.type} ref={ref => {this.camera = ref}}> | ||
| <View style={{ flex: 1, backgroundColor: 'transparent', flexDirection: 'row',}}> | ||
| <TouchableOpacity style={{ flex: 0.1, alignSelf: 'flex-end', alignItems: 'center',}} |
There was a problem hiding this comment.
we should not apply styles in DOM directly, because of rendering parser
We keep styles nice if:
- By moving styles away from the render function, you're making the code easier to understand.
- Naming the styles is a good way to add meaning to the low level components in the render function.
| <Text style={styles.text}>Please center your passport in the area above. Ensure that there’s enough light in the room for better picture quality.</Text> | ||
| <View> | ||
| {/* <TouchableOpacity style={styles.button} | ||
| {/*<TouchableOpacity style={styles.button} |
Pull request needs refactoring and improvements suggestions
Follow:
Goal of pull request is to technically improve new code and to perform team rules while contributing