resolve the issue with popover spewing componentWillReceiveProps deprecation warnings #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to check each of them respectively (like how the component worked previously)
xxx
commented
Jan 30, 2020
| @@ -0,0 +1,268 @@ | |||
| "use strict"; | |||
Author
There was a problem hiding this comment.
The build dir is included so we can use this directly from github
xxx
commented
Jan 30, 2020
| } | ||
| componentDidUpdate(propsPrev, statePrev) { | ||
| //log(`Component did update!`) | ||
| const willOpen = !propsPrev.isOpen && this.props.isOpen |
Author
There was a problem hiding this comment.
this is the only actual change. See 457401b for the original change that doesn't go far enough.
pvenable
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a PR up at jasonkuhrt/react-popover#208, but it doesn't actually work AFAICT (tested in their own storybook locally). The problem is that the check for state change isn't enough, as it creates a chicken and egg problem with when the containerEl field is set on the popover ref - the state doesn't change initially.
The state can't be assumed to change always, so go back to checking props for opening/closing, the way the component worked previously (except do it in componentDidUpdate to prevent the warning spew)