Skip to content

🐛 Some rare journeys have more trips than allowed by number of rounds #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Catatomik merged 3 commits into from
Sep 14, 2025
Merged

🐛 Some rare journeys have more trips than allowed by number of rounds #299

Catatomik merged 3 commits into from
Sep 14, 2025

Conversation

@Catatomik
Copy link
Member

@Catatomik Catatomik commented Sep 14, 2025

Closes #290

@Catatomik Catatomik self-assigned this Sep 14, 2025
@Catatomik Catatomik added the bug Something isn't working label Sep 14, 2025
@Catatomik Catatomik linked an issue Sep 14, 2025 that may be closed by this pull request
Some (rare) journeys have more trips than allowed by number of rounds #290
Closed
@qltysh
Copy link

qltysh bot commented Sep 14, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will decrease coverage by 0.02%.

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@Catatomik
Copy link
Member Author

Catatomik commented Sep 14, 2025

Passes real-world tests
It would need a special case failing example to be perfect

@Catatomik Catatomik merged commit b51857f into dev Sep 14, 2025
1 check passed
@Catatomik Catatomik mentioned this pull request Sep 14, 2025
Closed
@Catatomik Catatomik deleted the 290-some-rare-journeys-have-more-trips-than-allowed-by-number-of-rounds branch September 14, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Catatomik Catatomik

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some (rare) journeys have more trips than allowed by number of rounds

2 participants

@Catatomik