Fix useWidgetFetch to fetch data on source changes#934
Merged
Conversation
Pull Request Test Coverage Report for Build 14056448577Details
💛 - Coveralls |
|
Visit the preview URL for this PR (updated for commit d2267f9): https://cartodb-fb-storybook-react-dev--pr934-bug-sc-478442-wi-8rgllvfm.web.app (expires Tue, 01 Apr 2025 09:50:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c |
jmgaya
approved these changes
Mar 25, 2025
donmccurdy
approved these changes
Mar 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/478442
In
useWidgetFetchthesourcecontains filters, so it's needed as dependency touseEffectthat runs model against new parametersType of change
Acceptance
Change of filters should refetch widgets automatically, not waiting for other changes like viewport.
If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.
Basic checklist