Skip to content

Fix useWidgetFetch to fetch data on source changes#934

Merged
zbigg merged 3 commits intomasterfrom
bug/sc-478442/widget-not-updated-after-filtering-widgets
Mar 25, 2025
Merged

Fix useWidgetFetch to fetch data on source changes#934
zbigg merged 3 commits intomasterfrom
bug/sc-478442/widget-not-updated-after-filtering-widgets

Conversation

@zbigg
Copy link
Contributor

@zbigg zbigg commented Mar 25, 2025

Description

Shortcut: https://app.shortcut.com/cartoteam/story/478442

In useWidgetFetch the source contains filters, so it's needed as dependency to useEffect that runs model against new parameters

Type of change

  • Fix

Acceptance

Change of filters should refetch widgets automatically, not waiting for other changes like viewport.

If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@zbigg zbigg requested review from donmccurdy and jmgaya March 25, 2025 08:58
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

Pull Request Test Coverage Report for Build 14056448577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.144%

Totals Coverage Status
Change from base Build 13992997135: 0.0%
Covered Lines: 2900
Relevant Lines: 3727

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

Visit the preview URL for this PR (updated for commit d2267f9):

https://cartodb-fb-storybook-react-dev--pr934-bug-sc-478442-wi-8rgllvfm.web.app

(expires Tue, 01 Apr 2025 09:50:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@zbigg zbigg merged commit 2b261bb into master Mar 25, 2025
2 checks passed
@zbigg zbigg mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants