Skip to content

feat(widgets): Remove spatialFiltersResolution#930

Merged
donmccurdy merged 4 commits intomasterfrom
feat/sc-469614/remove-spatialFiltersResolution
Mar 17, 2025
Merged

feat(widgets): Remove spatialFiltersResolution#930
donmccurdy merged 4 commits intomasterfrom
feat/sc-469614/remove-spatialFiltersResolution

Conversation

@donmccurdy
Copy link
Contributor

Description

Shortcut: https://app.shortcut.com/cartoteam/story/469614/remove-the-spatialfiltersresolution-from-client-packages

Remove 'spatialFiltersResolution'. The API now determines this based on the spatial filter, not based on the viewport.

Type of change

  • Feature

Acceptance

n/a

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@donmccurdy donmccurdy requested a review from zbigg March 14, 2025 15:01
@github-actions
Copy link

github-actions bot commented Mar 14, 2025

Visit the preview URL for this PR (updated for commit 1c88d39):

https://cartodb-fb-storybook-react-dev--pr930-feat-sc-469614-r-geg7feia.web.app

(expires Mon, 24 Mar 2025 20:24:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 517cc4d31d7e09cf277774e034094b67c301cd4c

@coveralls
Copy link
Collaborator

coveralls commented Mar 14, 2025

Pull Request Test Coverage Report for Build 13909039524

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 71.455%

Files with Coverage Reduction New Missed Lines %
packages/react-widgets/src/hooks/useWidgetFetch.js 1 87.84%
Totals Coverage Status
Change from base Build 13432625849: 0.5%
Covered Lines: 2895
Relevant Lines: 3729

💛 - Coveralls

@donmccurdy donmccurdy merged commit fc5bf10 into master Mar 17, 2025
2 checks passed
@donmccurdy donmccurdy deleted the feat/sc-469614/remove-spatialFiltersResolution branch March 17, 2025 20:25
},
[
params,
enrichedSource,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need source (not enriched as it's outdated but any) as input to useEffect that runs model against new parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants