Skip to content
This repository was archived by the owner on Aug 4, 2019. It is now read-only.

Feature/email verification#45

Open
tina-t2 wants to merge 7 commits intodevelopfrom
feature/email-verification
Open

Feature/email verification#45
tina-t2 wants to merge 7 commits intodevelopfrom
feature/email-verification

Conversation

@tina-t2
Copy link

@tina-t2 tina-t2 commented Jul 31, 2019

No description provided.

@tina-t2 tina-t2 added the feature add some ability label Jul 31, 2019
@tina-t2 tina-t2 self-assigned this Jul 31, 2019
@ramtintk
Copy link

ramtintk commented Aug 3, 2019

Chapter One (UI):

  1. [Optional] Email verification lacks validation on things like @ and dot (.)

Chapter Two (Code):

  1. [Optional] mEmailLength inside companion object rather than an instant variable.

[Optional] It could be an if statement. when used in place of nested if-else

when (it.status) { Status.FAILED -> enableContinueButton() }

  1. Instant Karma (Or as they say karma is a ...) :| p0, p2 and ....

override fun beforeTextChanged(p0: CharSequence?, p1: Int, p2: Int, p3: Int) {}

  1. mSetEmailResponseLivadata spelling is wrong

@tina-t2
Copy link
Author

tina-t2 commented Aug 3, 2019

Chapter One (UI):

  1. [Optional] Email verification lacks validation on things like @ and dot (.)

Chapter Two (Code):

  1. [Optional] mEmailLength inside companion object rather than an instant variable.

[Optional] It could be an if statement. when used in place of nested if-else

when (it.status) { Status.FAILED -> enableContinueButton() }

  1. Instant Karma (Or as they say karma is a ...) p0, p2 and ....

override fun beforeTextChanged(p0: CharSequence?, p1: Int, p2: Int, p3: Int) {}

  1. mSetEmailResponseLivadata spelling is wrong

One:
1- Fixed

Two:
1- Edited
2- Other statuses will be added soon.
3- I just had edited names for arguments that I use.
4- Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature add some ability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants