This repository was archived by the owner on Aug 4, 2019. It is now read-only.
Open
Conversation
tina-t2
suggested changes
Aug 1, 2019
tina-t2
left a comment
tina-t2
left a comment
There was a problem hiding this comment.
Perfect.
1- Just a little test is needed.
2- Is space validate for a password?
3- Temp in drawable is not meaningful.
4- There was a ValidatorUtil class in the util package. Can you move your validator's code there?
app/src/main/java/de/netalic/peacock/ui/login/password/PasswordLoginFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/netalic/peacock/ui/login/password/PasswordLoginViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/netalic/peacock/ui/login/password/PasswordLoginFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/netalic/peacock/ui/login/password/PasswordLoginViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/netalic/peacock/ui/login/password/PasswordLoginFragment.kt
Show resolved
Hide resolved
| if (status == ResponseStatus.PASSWORD_MATCH) { | ||
| Toast.makeText(context, "Password Match", Toast.LENGTH_LONG).show() | ||
| mButtonContinue.isEnabled = true | ||
| mButtonContinue.backgroundTintList = ContextCompat.getColorStateList(requireContext(), R.color.colorTertiary) |
There was a problem hiding this comment.
It needs a selector to handle the button color.
I have that selector in the registration branch in drawable, you can take it to prevent the conflict.
Miladsalimiiiii
suggested changes
Aug 1, 2019
Author
|
@Miladsalimiiiii @tina-t2 |
Author
|
Review my master peace |
Miladsalimiiiii
approved these changes
Aug 3, 2019
Author
|
@Miladsalimiiiii |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login with password in renewed.