Skip to content
This repository was archived by the owner on Aug 4, 2019. It is now read-only.

Feature/codeverification#20

Open
miladsalimiiii wants to merge 16 commits intodevelopfrom
feature/codeverification
Open

Feature/codeverification#20
miladsalimiiii wants to merge 16 commits intodevelopfrom
feature/codeverification

Conversation

@miladsalimiiii
Copy link
Contributor

@miladsalimiiii miladsalimiiii commented Jul 24, 2019

No description provided.

@miladsalimiiii
Create code verification layout , closed #9
1def390
@miladsalimiiii
Work on code verification view model , issue #11 , work on user repos…
3ade9c1 
…itory , issue #13 , work on retrofit configuration , issue #14 , work on code verification view , issue #10
@miladsalimiiii
Create fragment util , closed #17 , work on code verification view is…
9bc6909 
…sue #10 and code verification view model , issue #11 and add base view model
@miladsalimiiii
Create app module for DI , closed #19 , retrofit configuration , closed
8d284c5 
#14 , create user repository  , closed #13 , create verification code viewmodel , clsoed #11 , create verification code view , closed #10
@miladsalimiiii miladsalimiiii self-assigned this Jul 24, 2019
@HankMody69
Copy link

HankMody69 commented Jul 27, 2019

@miladsalimiiii
Hello my good friend the problems inside your development are listed below:

  1. Switch your theme to newer and recommended Theme.MaterialComponents.DayNight.NoActionBar
  2. After clicking button it turns into unreadable color
  3. Stylex.xml font styles are a little bit off, extend from MaterialDesign TextView
  4. [Optinal] Add initUiComponents to BaseFragment.kt
  5. In CodeVerificationFragment added many properties of views that never been used.
  6. FragmentUtil is a class that includes a single companion object? :|

@Miladsalimiiiii Miladsalimiiiii requested review from ehsan-mashhadi and tina-t2 and removed request for EhsanMashhadi and TinaT2 July 28, 2019 05:28
tina-t2
tina-t2 suggested changes Jul 28, 2019
View reviewed changes
@Miladsalimiiiii
Copy link

Miladsalimiiiii commented Jul 28, 2019

@miladsalimiiii
Hello my good friend the problems inside your development are listed below:

1. Switch your theme to newer and recommended Theme.MaterialComponents.DayNight.NoActionBar

2. After clicking button it turns into unreadable color

3. Stylex.xml font styles are a little bit off, extend from MaterialDesign TextView

4. [Optinal] Add initUiComponents to BaseFragment.kt

5. In CodeVerificationFragment added many properties of views that never been used.

6. FragmentUtil is a class that includes a single companion object? :|

Hi dear Ramtin
1-It will be fix after merging
2-I do not face with this situation
3-It will be fix after merging
4-Fixed
5-If it does not use in my new feature branch i remove them
6-Fixed

@Miladsalimiiiii Miladsalimiiiii requested review from ramtintk and tina-t2 and removed request for HankMody69 July 28, 2019 09:29
@tina-t2 tina-t2 force-pushed the feature/codeverification branch from 164ecca to aded398 Compare July 29, 2019 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ehsan-mashhadi ehsan-mashhadi Awaiting requested review from ehsan-mashhadi

@tina-t2 tina-t2 Awaiting requested review from tina-t2

2 more reviewers

@Miladsalimiiiii Miladsalimiiiii Miladsalimiiiii left review comments

@ramtintk ramtintk ramtintk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miladsalimiiii @HankMody69 @Miladsalimiiiii @tina-t2 @ramtintk @ehsan-mashhadi