Add player state and refactor inter task communication#203
Open
luar123 wants to merge 2 commits intoCarlosDerSeher:refactor_parserfrom
Open
Add player state and refactor inter task communication#203luar123 wants to merge 2 commits intoCarlosDerSeher:refactor_parserfrom
luar123 wants to merge 2 commits intoCarlosDerSeher:refactor_parserfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds player state + callbacks and refactors the inter task communication.
player_send_snapcast_settingI am unsure about the task notifications, had a race conditions when using them in the callbacks (that's why the main task callback uses a mutex). So maybe it would be better to use mutex or queues instead.
Todo: Either change notifications or set configTASK_NOTIFICATION_ARRAY_ENTRIES=2 in sdkconfigs.
@craigmillard86 Using this PR network_playback_stopped/network_playback_started from #201 could be replaced by a state callback.