Skip to content

Comments

feat: Unified ethernet and WiFi network handling with static IP support#199

Closed
CarlosDerSeher wants to merge 1 commit intoCarlosDerSeher:refactor_parserfrom
anabolyc:feature/unified-ethernet
Closed

feat: Unified ethernet and WiFi network handling with static IP support#199
CarlosDerSeher wants to merge 1 commit intoCarlosDerSeher:refactor_parserfrom
anabolyc:feature/unified-ethernet

Conversation

@CarlosDerSeher
Copy link
Owner

This commit consolidates 86 commits of development work implementing:

  • Unified ethernet and WiFi network interface management
  • Ethernet with static IP configuration support
  • WiFi failover when ethernet disconnects
  • Ethernet priority with automatic failover to WiFi
  • IPv6 support with fallback to IPv4
  • Improved network robustness and error handling
  • Global restart button for network recovery
  • Web UI for ethernet static IP configuration
  • Proper cleanup and resource management
  • Various bug fixes and stability improvements

Key changes:

  • Merged separate ethernet and WiFi components into unified network interface
  • Added persistent Ethernet static IP configuration via Kconfig
  • Implemented proper connection state management with FreeRTOS EventGroups
  • Added gateway reachability checks with IPv6 fallback
  • Fixed race conditions in player startup/shutdown
  • Improved DHCP restart handling
  • Reduced buffer allocation for PSRAM-less devices (750ms -> 700ms)

This commit consolidates 86 commits of development work implementing:

- Unified ethernet and WiFi network interface management
- Ethernet with static IP configuration support
- WiFi failover when ethernet disconnects
- Ethernet priority with automatic failover to WiFi
- IPv6 support with fallback to IPv4
- Improved network robustness and error handling
- Global restart button for network recovery
- Web UI for ethernet static IP configuration
- Proper cleanup and resource management
- Various bug fixes and stability improvements

Key changes:
- Merged separate ethernet and WiFi components into unified network interface
- Added persistent Ethernet static IP configuration via Kconfig
- Implemented proper connection state management with FreeRTOS EventGroups
- Added gateway reachability checks with IPv6 fallback
- Fixed race conditions in player startup/shutdown
- Improved DHCP restart handling
- Reduced buffer allocation for PSRAM-less devices (750ms -> 700ms)
@CarlosDerSeher CarlosDerSeher marked this pull request as draft February 11, 2026 12:17
@CarlosDerSeher
Copy link
Owner Author

CarlosDerSeher commented Feb 11, 2026

@craigmillard86 As I feared, We have a lot of conflicts with the parser refactor. I did not merge those changes yet but put it to a seperate branch for now to see how we can integrate ethernet changes there. I saw that we have those confilcts in #195 too...

@blattm maybe you could be of assitence here too

@luar123
Copy link
Contributor

luar123 commented Feb 11, 2026

Something is messed up with the commits. There are many unrelated changes. Same in #195.

@craigmillard86
Copy link

Something is messed up with the commits. There are many unrelated changes. Same in #195.

yeah you are right, looks like i based on Master for some reason!! I am looking into rebasing to develop

@CarlosDerSeher
Copy link
Owner Author

CarlosDerSeher commented Feb 11, 2026

@craigmillard86 Could you possible rebase to refactor parser branch?

@craigmillard-hha
Copy link

@craigmillard86 Could you possible rebase to refactor parser branch?

Yep, will rebase to develop first as will reduce complexity then look at merge to refactor parser branch

@blattm
Copy link
Contributor

blattm commented Feb 11, 2026

Yes, doing it in two steps (first develop then refactor-parser) seems like the way to go!

For the second step, I can share the strategy that worked best for me so far:
In case there are huge conflicts, accept the refactor-parser version. Then go through each change in main.c of the new feature (compared to dev), think where it would belong now (main.c, connection_handler, ...), and insert it there manually.

Let me know if you need help! :)

@craigmillard86
Copy link

Think i have the first stage complete here: https://github.com/anabolyc/esp32-snapclient/tree/feature/unified-eth-develop
Need to find some time to test unless @CarlosDerSeher are you still setup to test ethernet?

@CarlosDerSeher
Copy link
Owner Author

Yes, but today I won't have time. Earliest tomorrow evening

@luar123
Copy link
Contributor

luar123 commented Feb 12, 2026

There are still some changes reverting recent commits, for example in sdkconfig and player.c. Probably also in other files but hard to tell.

@CarlosDerSeher
Copy link
Owner Author

@craigmillard86 I guess this can be closed too?

@craigmillard86
Copy link

craigmillard86 commented Feb 12, 2026

@craigmillard86 I guess this can be closed too?

yep no longer needed, please close will open a new one to merge the new branch to the refactor branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants