Merge original repo changes #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the most obvious thread safety issues in RecordHandler when dealing with HashMaps.
- Fix a thread safety issue with the Record usage count. The scenario this fixes is as follows (t1 and t2 are independent threads):
t1 - foo_t1 = client.record.getRecord("foo")
t1 - foo_t1.discard() preempts just after if( this.usages <= 0 )
t2 - foo_t2 = client.record.getRecord("foo")
t1 - resumes and finishes foo_t1.discard()
t2 - resumes and is now using a record that had destroy() called on it
- Fix the following whenReady thread safety bug:
t1: Record.whenReady(): preempts after "} else {"
t2: Record.setReady()
t2: Resumes and adds record to onceRecordReadyListeners, which will never be called because setReady has already been called. This will result in a hang.
- Add threaded test to RecordTest. This test will hang when run on code before this commit.
Fix thread safety problems. Fixes deepstreamIO#109.
Fixed NPE when being called for unknown event types (see issue deepstreamIO#131)
…in order to handle this disconnection
Fix connection status when deepstream is lost connection to be error …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.