Upgrade to latest ember addon spec#1
Open
mansona wants to merge 3 commits intoCapyTheBeara:masterfrom
Open
Conversation
Author
|
I've also got another pull request I can submit after this that adds some google plus apis to the client. I based it on this PR HEAD so we'd need to get this merged first. Also I managed to get this working fine in a project of mine so it's been tested and verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there,
I wanted to try out your google api client but i was using a recent version of ember-cli and needed an up-to-date implementation, so here you go 🎉
I have tried to change as little as i possibly can. The only thing that really changed in any meaningful way is the namespace of the internal files. I don't know how this will affect the plugin once it's being imported but i suppose it will be worth you testing this in one of your existing apps.
All the tests are now passing and the new addon structure has a travis config so once/if you merge this PR we can setup travis to build the plugin.
Also it's worth publishing this on npm too, I can do that for you if you like simply 2 command for me but let me know what you think.
Cheers!