dev.sh db to connect to mysql client CLI #615
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renoirb
force-pushed
the
dev-sh-db-mysql
branch
from
fc4c689 to
8164ed3
Compare
Instead of using an external MariaDB/MySQL client, we can use the container's internal mysql client directly. Since it's a container for development, and WordPress instance expects only one database, we can assume that this won't do anything in other contexts.
renoirb
force-pushed
the
dev-sh-db-mysql
branch
from
8164ed3 to
108a3d1
Compare
renoirb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using an external MariaDB/MySQL client, we can use the container's internal
mysqlclient directly.The convention being that if
db-shellgets into a bash CLI,db-dumpcreates a database backup,dbalone gives access to the main purpose of that container.Since it's a container for development, and WordPress instance expects only one database, we can assume that this won't do anything in other contexts.