make both fw-child/apps/app-download.php and app-map.php to have only code as differences

[renoirb]

Description

Both files are essentially the same, other than one word or the other.

(This is also just a quick stub to discuss what other expectations in commit and PR documentation going)

PS: I'm deliberately not proposing to have one file with everything and another with much less. It's been about 7 years I haven't written PHP, and in this context, WordPress has different ways of working and expectations that I need to re-familiarize myself with.

Goal

Make the difference between files only the meaningful ones

red (with <, the "left side" in the diff) below is for app-download.php, green is on the right side

diff app-download.php app-map.php 
3c3
<  * Template Name: fw-child/apps/app-download.php
---
>  * Template Name: fw-child/apps/app-map.php
13c13
< $assets = cdc_app_asset_load( 'download' );
---
> $assets = cdc_app_asset_load( 'map' );
31a32
> 
33a35,43
> 
> 	'about-data-en' => '/about/our-data/',
> 	'about-data-fr' => '/le-portail/nos-donnees/',
> 
> 	'support-en' => '/feedback/',
> 	'support-fr' => '/retroaction/',
> 
> 	'download-en' => '/download/',
> 	'download-fr' => '/telechargement/',
66a77,79
>         // URL encoder salt for the app
>         window.URL_ENCODER_SALT = '<?php echo isset( $GLOBALS['vars']['url_encoder_salt'] ) ? htmlspecialchars( $GLOBALS['vars']['url_encoder_salt'], ENT_QUOTES, 'UTF-8' ) : ''; ?>';
> 

Related ticket