-
Notifications
You must be signed in to change notification settings - Fork 2
Xp/simple version #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…o two 1D gaussian functions (column sum and row sum) made a test file for this object. Tests pass
…t and explicit calling
…camera is seeing some thing. no image displays though
Xp/adding zoom
Xp/add exposure bar
exposure bar now follows exposure values correctly
|
@gregllong , what is the picamera file at the top of the repository? |
|
@gregllong , you also might be best suited to inserting a requirements.txt for pip installation. |
|
@gregllong this is all looking good. Looking forward to forcing the 180Q kids to use it lol |
|
@gregllong are you planning on adding high resolution mode and the live fitting plot? if we get those things added I say we just go with your profiler since it has more activity |
|
@aransfor I am looking into the high resolution mode right now, and I think the live fitting is available (we just want two 1D gaussian fit, right?). I'm thinking about having a calibration function somewhere accessible, but for now maybe hard-coding the proportionality constants for different colors are fine. |
|
@jayich thanks for pointing the picamera file out. I just deleted it and looks like it's not doing anything. |
|
@gregllong , I would hard-code the proportionality constant. That is bonus functionality and should be part of a future (smaller) PR. |
|
@gregllong I wouldnt call it a calibration function (this makes it sound like it will drift or something). There should just be one number that scales the array properly. I agree with @jayich that it should be hard coded. Have we figured out how to get the raw bayer data off this camera or are we still using processed image data? |
|
I'm not sure what it means by bayer data. I think what I did to get the different colors of arrays is by taking out the RGBArray from the picamera image and picking the indices accordingly (0 for red, 1 for green, and 2 for blue). I should probably dive deeper into this... |
|
@gregllong , I would dive deeper in a separate PR, unless this would be lost functionality. This PR is long enough. |
|
damn I need to figure out how to sign out that Max account on the Pi. |
removed a redundant file, and changed import path for test files so t…
@jayich @aransfor Sorry for the delay. This is the same pull request for the reduced version of PiBeamProfiler.