Skip to content

Conversation

@gregllong
Copy link

@jayich @aransfor Sorry for the delay. This is the same pull request for the reduced version of PiBeamProfiler.

gregllong and others added 30 commits June 2, 2016 16:04
…o two 1D gaussian functions (column sum and row sum)

made a test file for this object. Tests pass
…camera is seeing some thing. no image displays though
@jayich
Copy link

jayich commented Dec 27, 2016

@gregllong , what is the picamera file at the top of the repository?

@jayich
Copy link

jayich commented Dec 27, 2016

@gregllong , you also might be best suited to inserting a requirements.txt for pip installation.

@aransfor
Copy link

@gregllong this is all looking good. Looking forward to forcing the 180Q kids to use it lol

@aransfor
Copy link

@gregllong are you planning on adding high resolution mode and the live fitting plot? if we get those things added I say we just go with your profiler since it has more activity

@gregllong
Copy link
Author

@aransfor I am looking into the high resolution mode right now, and I think the live fitting is available (we just want two 1D gaussian fit, right?). I'm thinking about having a calibration function somewhere accessible, but for now maybe hard-coding the proportionality constants for different colors are fine.

@gregllong
Copy link
Author

@jayich thanks for pointing the picamera file out. I just deleted it and looks like it's not doing anything.

@jayich
Copy link

jayich commented Dec 27, 2016

@gregllong , I would hard-code the proportionality constant. That is bonus functionality and should be part of a future (smaller) PR.

@aransfor
Copy link

@gregllong I wouldnt call it a calibration function (this makes it sound like it will drift or something). There should just be one number that scales the array properly. I agree with @jayich that it should be hard coded. Have we figured out how to get the raw bayer data off this camera or are we still using processed image data?

@gregllong
Copy link
Author

I'm not sure what it means by bayer data. I think what I did to get the different colors of arrays is by taking out the RGBArray from the picamera image and picking the indices accordingly (0 for red, 1 for green, and 2 for blue). I should probably dive deeper into this...

@jayich
Copy link

jayich commented Dec 28, 2016

@gregllong , I would dive deeper in a separate PR, unless this would be lost functionality. This PR is long enough.

@gregllong
Copy link
Author

damn I need to figure out how to sign out that Max account on the Pi.

removed a redundant file, and changed import path for test files so t…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants