Skip to content

fix(rust): wasm-pack arguments + fix libs/apps relative paths#22

Open
dearlordylord wants to merge 2 commits intoCammisuli:mainfrom
dearlordylord:main
Open

fix(rust): wasm-pack arguments + fix libs/apps relative paths#22
dearlordylord wants to merge 2 commits intoCammisuli:mainfrom
dearlordylord:main

Conversation

@dearlordylord
Copy link

This PR solves two issues that are interconnected in code

  • wasm-pack doesn't recognize -p property and expects passing the project root without -p

  • the plugin code doesn't respect libs/apps folders and only uses the app name, not prefixing it, therefore it doesn't recognize if i.e. my libs dir = packages/, and my app is my-lib, it'll search in ./my-lib instead of ./packages/my-lib

@Cammisuli
Copy link
Owner

Hey, thanks for the PR!

I haven't actually finished the wasm support for the plugin, but I'm happy you're testing it out 😄

I'll take a look as soon as I can.

@dearlordylord
Copy link
Author

Thank you for checking this. For more context: It kinda works for me, the target does build the wasm and all and I can pick it up in my ts app through alias, although the implementation is very basic indeed i.e. I need to rebuild the wasm on every change

@maxmousse maxmousse mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants