Field interface to accept particles or coords #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriaRaffuzzi
approved these changes
Dec 12, 2025
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
Looks good to me - it's a good tradeoff in the meantime and hopefully it doesn't break anything down the line in multi-physics.
Could complete the tests, but that's pretty much it.
|
|
||
| ! Check value | ||
| @assertEqual([9.6_defReal, -8.0_defReal, 9.7_defReal], fieldT % at(p), TOL) | ||
| @assertEqual([9.6_defReal, -8.0_defReal, 9.7_defReal], fieldT % atP(p), TOL) |
Collaborator
Author
There was a problem hiding this comment.
This one does do both atP and at. It can't be done for the UFS field and WW field though because they only define atP and give a fatalError for at.
Co-authored-by: valeriaRaffuzzi <108435337+valeriaRaffuzzi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface of the field was changed in the creation of Weight Windows/Uniform Fission Sites. This complicates using fields in geometry as it requires sending particle information into geometry, which makes it complicated to use, e.g., pieceConstantFields during tracking.
This proposal expands the field interface to allow them to accept both coordinates (in their original spirit) and particles (maintaining their use in support of WWs and UFS). This adds an 'atP' function to get the field value at the phase space coordinates of the particle, rather than just at the position.
There might be some other alternative where, e.g., a WW object is defined containing an energy map over fields. I'm not against that being considered in future, but I think this is reasonable to enable multiphysics meanwhile.