Skip to content

Conversation

@valeriaRaffuzzi
Copy link
Member

Adding the capability to micro and macro Responses to get a larger set of MT numbers as input.

@valeriaRaffuzzi valeriaRaffuzzi added enhancement New feature or request Tallies labels Oct 24, 2025
@valeriaRaffuzzi valeriaRaffuzzi marked this pull request as ready for review October 24, 2025 18:19
Copy link
Collaborator

@ChasingNeutrons ChasingNeutrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the handful of aesthetic things to fix.

!! NOTE: despite being in the interface, this function only makes sense
!! for CE. The MG extension returns a fatalError if called
!!
function getMTxs(self, MT, p) result(xs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can this not work for MG? Can't certain MT numbers be included/excluded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a MG material you can only look up the cross sections you provide. Those are legit tally responses, but are not provided by getMTxs (they are looked up from the xss Packages directly). Otherwise, the ENDF MT numbers don't exist in MG.

@valeriaRaffuzzi valeriaRaffuzzi merged commit bd300f3 into CambridgeNuclear:main Oct 27, 2025
5 checks passed
@valeriaRaffuzzi valeriaRaffuzzi deleted the MTmaterialData branch October 27, 2025 12:27
@valeriaRaffuzzi valeriaRaffuzzi restored the MTmaterialData branch October 27, 2025 13:20
@valeriaRaffuzzi valeriaRaffuzzi deleted the MTmaterialData branch October 27, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Tallies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants