Fix bug in S(a,b) coherent elastic scattering angle sampling #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChasingNeutrons
approved these changes
Aug 22, 2025
Collaborator
ChasingNeutrons
left a comment
ChasingNeutrons
left a comment
There was a problem hiding this comment.
Thanks for finding this, great stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #169 : there was an error in the coherent elastic scattering angle sampling. The CDF to sample the Bragg edge the neutron scatters with was built incorrectly.
This only came up when trying running a model with a lot of graphite; it wasn't noticeable when smaller models were simulated.
Now SCONE agrees perfectly with Serpent.