Discontinuous field #171
Merged
Discontinuous field #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in the BEAVRS model with the D-bank partially inserted. Also fixed a flaw in the geometry where the outermost cell was defined such that there could be a rare particle lost between it and the geometry boundary.
Field which have values that are piecewise constant. Endowed with a distance calculation. Added a simple version which allows a lattice to be specified.
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
It all looks good to me, the main thing is that there is massive code duplication from latUniverse and it would be nice to avoid it. On the other hand these are not quite generic procedures and might never be used in a third location. Let's discuss it!
Geometry/Fields/ScalarFields/PieceConstantFields/pieceConstantField_inter.f90
Outdated
Show resolved
Hide resolved
Geometry/Fields/ScalarFields/PieceConstantFields/cartesianField_class.f90
Outdated
Show resolved
Hide resolved
Geometry/Fields/ScalarFields/PieceConstantFields/cartesianField_class.f90
Show resolved
Hide resolved
Geometry/Fields/ScalarFields/PieceConstantFields/cartesianField_class.f90
Show resolved
Hide resolved
Geometry/Fields/ScalarFields/PieceConstantFields/cartesianField_class.f90
Show resolved
Hide resolved
Geometry/Fields/ScalarFields/PieceConstantFields/cartesianField_class.f90
Show resolved
Hide resolved
Geometry/Fields/ScalarFields/PieceConstantFields/cartesianField_class.f90
Show resolved
Hide resolved
Geometry/Fields/ScalarFields/PieceConstantFields/cartesianField_class.f90
Outdated
Show resolved
Hide resolved
valeriaRaffuzzi
approved these changes
Dec 15, 2025
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
All good for me! I am happy with the all comments/replies.
valeriaRaffuzzi
added a commit
that referenced
this pull request
Dec 15, 2025
This reverts commit 2d14326.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a field which supports distance calculations to where the value of the field changes. This is hoped to support upcoming multiphysics features alongside both surface and delta tracking.
I have implemented an abstract class plus a derived type which allows a lattice-like spatial structure. Hopefully it should be easy to extend to more general fields.
In an upcoming PR I hope to add checks for this field for both temperature and density, allowing geometryStd to account for it during move.
Please let me know if this abstraction makes sense or doesn't.