K-implicit (n,2n) fix #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in the BEAVRS model with the D-bank partially inserted. Also fixed a flaw in the geometry where the outermost cell was defined such that there could be a rare particle lost between it and the geometry boundary.
Added more obscure channels to the multiplicative scattering tally in kImplicit.
ChasingNeutrons
commented
Jul 4, 2025
ChasingNeutrons
commented
Jul 4, 2025
| ! Assumes N_XNs are by implicit weight change | ||
| select case(MT) | ||
| case(N_2N) | ||
| case(N_2Nd, N_2N, N_2Na, N_2N2a, N_2Np, N_3Np, N_2N0:N_2Ncont) |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| case(N_2Nd, N_2N, N_2Na, N_2N2a, N_2Np, N_3Np, N_2N0:N_2Ncont) | |
| case(N_2Nd, N_2N, N_2Na, N_2N2a, N_2Np, N_2N0:N_2Ncont) |
valeriaRaffuzzi
requested changes
Jul 9, 2025
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
There might be conflicts with the BEAVRS input that was just merged in another PR.
Once the commits are sorted (just noting that the MT numbers were already there in a more compact form) this is good to go!
Co-authored-by: valeriaRaffuzzi <108435337+valeriaRaffuzzi@users.noreply.github.com>
Co-authored-by: valeriaRaffuzzi <108435337+valeriaRaffuzzi@users.noreply.github.com>
For consistency with inelastic scattering
valeriaRaffuzzi
approved these changes
Jul 23, 2025
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
If this passes all the tests, I think this is ok now! Feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously k implicit only had a few multiplicative scattering channels it considered. This seemed to work well mostly, but, for JEFF with Be, this could cause significant keff bias. Hence I have added in MTs 875-891 which are discrete and continuous (n,2n) levels. These have also been added to endfConstants. I added a few others which we already had in endfConstants too, but in this case MTs 875-891 were the culprits.