Fix bug in building thermalScatterElastic_class.f90 #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChasingNeutrons
approved these changes
Jun 5, 2025
Collaborator
ChasingNeutrons
left a comment
ChasingNeutrons
left a comment
There was a problem hiding this comment.
Would it be worth making an integration test for this?
Member
Author
There are some integration tests for Sab, but this was probably an edge case not captured.. Could be added as an issue for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two errors in one line! That was on me...
The mu distributions should be real rather than integers, and the size of the array to be read was also wrong.
My guess is that this didn't come up sooner because water and graphite (most commonly used) don't have this angular representation, while it showed up in poly.
This solves issue #157.