Quadric surface #135
Open
Quadric surface #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required a change to dictionary reading to allow mixed character/number reading. Also fixed some comments in nearby files.
Adds a general quadratic shape. Also removed dotProduct from surfaces in favour of intrinsic dot_product.
valeriaRaffuzzi
requested changes
Dec 8, 2024
Member
valeriaRaffuzzi
left a comment
valeriaRaffuzzi
left a comment
There was a problem hiding this comment.
All good to me! The only doubt is about the surface tolerance, I am not convinced about that but I don't think I have a better suggestion for now. We should think about this a bit more I think.
| !! | ||
| !! F(x,y,z) = Ax^2 + By^2 + Cz^2 + Dxy + Eyz + Fzx + Gx + Hy + Iz + J | ||
| !! | ||
| !! Surface tolerance: 2 * max(coeffs) * SURF_TOL |
Member
There was a problem hiding this comment.
why max(coeffs) as tolerance?
Collaborator
Author
There was a problem hiding this comment.
I don't really have a good answer for this. I haven't been able to find a good prescription for this anywhere. Might it be fine for now?
Also addresses some PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a general quadratic shape of the form:
F(x,y,z) = Ax^2 + By^2 + Cz^2 + Dxy + Eyz + Fxz + Gx + Hy + Jz + I
Also removed dotProduct from surfaces in favour of intrinsic dot_product.