Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made some edits to the paper, including adding some citations. The edits have included some reorganization, which makes the diff look (maybe) more significant than it really is. I'm happy to iterate on this.
After reviewing a number of papers on JOSS, I've seen that they commonly start with a short summary (acting in place of a typical abstract), followed by the statement of need, and then any number of other sections with headings chosen by the authors.
Here I've adjusted the paper have the sections:
Summary
Statement of need
Functionality
While I've continued acknowledging the original Matlab SubZero by Brandon and Georgy, I've tried to make direct comparisons less of the focus of this paper and instead highlight the utility of Subzero.jl.
Speed tests still haven't been performed, so that section remains a stub, and figure references currently included are still placeholders (and waiting to add figures before writing captions).