Use threading.Lock instead of QMutex to workaround QMutexLocker bug in PyQt6

[danielrh]

This solves #128

[dnadlinger]

Looks good to me. There doesn't seem to be any reason to use QMutex[Locker] in the first place – when recently fixing some of the threading issues, I just left it in because it was already in use in the previous version. I'd guess (famous last words) that just using threading.Lock is faster too.

[dnadlinger]

Unsurprisingly – now that we have @danielrh's root cause analysis showing that this is a bug in QMutexLocker independent of qasync –, this indeed seems to have fixed all qasync-related crashes in the deployments here.

It would be good to cut a release with this as a matter of urgency, as this greatly improves the stability on Windows. (I'm not sure whether it was the recent switch to Windows 11 in the deployment here or upgrading the PyQt/Qt versions, but the current state is almost unusably unstable for our applications.)

[dnadlinger]

@hosaka: In case reviewing the state of master regarding a new release takes more bandwidth than you have to spare right now, could we potentially just backport this to 0.27.1 and release it as a follow-up 0.27.2? (Given that I had a close look into the threading model in #87, I'm confident in saying that this is at least as correct as the previous implementation that hits the PyQt bug.)

[hosaka]

Hi, thanks for the PR. Can we get a rebase on top of master to resolve the conflicts? And yeah it's about time we make a new release.

[danielrh]

Sorry for the delay @hosaka : here's the rebase.

I didn't notice any conflicts during the rebase? Are you sure you have github set to rebase-and- during merge? because this was a purely automatic process here.

[hosaka]

Thanks, I could swear GitHub showed me a "cannot automatically rebase" message...

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
src/qasync
_windows.py					93-94, 97-98, 101-102, 109-110, 113-114, 117-118, 121-122
Project Total

This report was generated by python-coverage-comment-action